[Findit] Query master flake analyses 100 at a time and add previous/next buttons to check flake dash

[Findit] Query master flake analyses 100 at a time and add previous/next buttons to check flake dashboard

Sample page: https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

BUG=662562
Committed: https://chromium.googlesource.com/infra/infra/+/b0b95c0f42e36db94517e8f126931e127b86a55b

[lijeffrey, 2016-12-01 00:06:35]

Description was changed from

==========
[Findit] Fetch 100 flake analyses at a time


[Findit] Query master flake analyses 100 at a time


[Findit] Query master flake analyses 100 at a time and add previous/next buttons
to check flake dashboard

BUG=
==========

to

==========
[Findit] Query master flake analyses 100 at a time and add previous/next buttons
to check flake dashboard

BUG=662562
==========

[lijeffrey, 2016-12-01 00:06:35]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org

[lijeffrey, 2016-12-01 00:07:57]

Description was changed from

==========
[Findit] Query master flake analyses 100 at a time and add previous/next buttons
to check flake dashboard

BUG=662562
==========

to

==========
[Findit] Query master flake analyses 100 at a time and add previous/next buttons
to check flake dashboard

Sample page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

BUG=662562
==========

[lijeffrey, 2016-12-01 00:10:40]

This change should speed up the check flake dashboard a lot just by querying 100
at a time and adding a previous/next button at the bottom for browsing.

PTAL when you have the chance

[chanli, 2016-12-01 00:45:35]

Generally LGTM.

But from https://cloud.google.com/appengine/docs/python/ndb/queries, we can
simply use cursor to go previous or next, I think that'll be easier?

https://codereview.chromium.org/2546433003/diff/20001/appengine/findit/templa...
File appengine/findit/templates/flake/dashboard.html (right):

https://codereview.chromium.org/2546433003/diff/20001/appengine/findit/templa...
appengine/findit/templates/flake/dashboard.html:18: padding:0!important;
Question: what does this mean?

[lijeffrey, 2016-12-01 13:47:19]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-12-01 13:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org
Link to the patchset: https://codereview.chromium.org/2546433003/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-12-01 13:47:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lijeffrey, 2016-12-01 13:48:59]

I'm not familiar with the cursor approach, but from what I can tell it doesn't
seem there are any obvious benefits or drawbacks to either approach so I'll
leave it as it is for now and CQing this change to have in time for the
announcement/release (with a TODO that cursor should be explored)

https://codereview.chromium.org/2546433003/diff/20001/appengine/findit/templa...
File appengine/findit/templates/flake/dashboard.html (right):

https://codereview.chromium.org/2546433003/diff/20001/appengine/findit/templa...
appengine/findit/templates/flake/dashboard.html:18: padding:0!important;
On 2016/12/01 00:45:35, chanli wrote:
> Question: what does this mean?

Got it from config.html, which was probably used from some other sample code. It
doesn't appear to matter, so i removed the "!important" (which can cause other
problems) from both this file and config.html

[commit-bot: I haz the power, 2016-12-01 14:02:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480600039614850,
"parent_rev": "b46bc1bf6c0b9a81d66fd52ca1d3e89242407e9c", "commit_rev":
"b0b95c0f42e36db94517e8f126931e127b86a55b"}

[commit-bot: I haz the power, 2016-12-01 14:02:45]

Description was changed from

==========
[Findit] Query master flake analyses 100 at a time and add previous/next buttons
to check flake dashboard

Sample page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

BUG=662562
==========

to

==========
[Findit] Query master flake analyses 100 at a time and add previous/next buttons
to check flake dashboard

Sample page:
https://lijeffrey-dot-findit-for-me.appspot.com/waterfall/list-flakes

BUG=662562

Committed:
https://chromium.googlesource.com/infra/infra/+/b0b95c0f42e36db94517e8f126931...
==========

[commit-bot: I haz the power, 2016-12-01 14:02:46]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/b0b95c0f42e36db94517e8f126931...

[stgao, 2016-12-01 18:22:13]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2016-12-01 18:22:14]

not lgtm

This broke the filtering by status.
Was that tested at all?

[stgao, 2016-12-01 18:24:52]

On 2016/12/01 18:22:14, stgao (slow on Monday) wrote:
> not lgtm
> 
> This broke the filtering by status.
> Was that tested at all?

And the data on the result is not ordered.
On the default page, the data is from 2016-12-01 to 2016-10-02.
On the next page, the data is from 2016-12-01 to 2016-10-02 too.
This is wrong.

[stgao, 2016-12-01 18:26:06]

https://codereview.chromium.org/2546433003/diff/40001/appengine/findit/handle...
File appengine/findit/handlers/flake/list_flakes.py (right):

https://codereview.chromium.org/2546433003/diff/40001/appengine/findit/handle...
appengine/findit/handlers/flake/list_flakes.py:23: end_date=None,
status_code=result_status.UNSPECIFIED, offset=0):
We'd better use cursor instead of offset for performance, IIRC.