Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 254643002: Scrollbars should get notifications from all scrollable layers up to container. (Closed)

Created:
6 years, 8 months ago by wjmaclean
Modified:
6 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, bokan, Rick Byers
Visibility:
Public.

Description

Scrollbars should get notifications from all scrollable layers up to container. The thumb position of a scrollbar is dependant on the scroll offsets of all scrollable layers from the scrollbar's designated scroll layer up to its container layer. It also needs to know about geometry changes in its scroll and container layers. This CL revises the mechanism that registers a scrollbar to receive notifications to include all intervening scrollable layers. BUG=346393 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266674

Patch Set 1 #

Patch Set 2 : Fix test issues. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M cc/layers/scrollbar_layer_impl_base.cc View 1 2 chunks +36 lines, -8 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
wjmaclean
There are a small number of tests that are failing on this patch; I am ...
6 years, 8 months ago (2014-04-24 18:27:27 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 8 months ago (2014-04-24 20:46:01 UTC) #2
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 7 months ago (2014-04-28 17:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/254643002/20001
6 years, 7 months ago (2014-04-28 18:02:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 18:27:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 18:27:44 UTC) #6
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 7 months ago (2014-04-28 18:29:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/254643002/20001
6 years, 7 months ago (2014-04-28 18:30:18 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 18:47:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 18:47:08 UTC) #10
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 7 months ago (2014-04-28 19:31:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/254643002/20001
6 years, 7 months ago (2014-04-28 19:32:15 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 22:25:20 UTC) #13
Message was sent while issue was closed.
Change committed as 266674

Powered by Google App Engine
This is Rietveld 408576698