Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

Issue 2546423002: [Try # 3] Scheduler refactoring to virtually eliminate redundant DoWorks (Closed)
Patch Set: Fix lock order inversion Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
index 69224757e9407ae2dbb2b2c09dadfc48d5d1520d..09a253c862034ca0c9c4e04dcd9a247cac093e70 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
@@ -34,8 +34,8 @@ class MockTimeDomain : public TimeDomain {
using TimeDomain::NextScheduledTaskQueue;
using TimeDomain::ScheduleDelayedWork;
using TimeDomain::UnregisterQueue;
- using TimeDomain::UpdateWorkQueues;
- using TimeDomain::RegisterAsUpdatableTaskQueue;
+ using TimeDomain::OnQueueHasImmediateWork;
+ using TimeDomain::WakeupReadyDelayedQueues;
// TimeSource implementation:
LazyNow CreateLazyNow() const override { return LazyNow(now_); }
@@ -44,7 +44,10 @@ class MockTimeDomain : public TimeDomain {
void AsValueIntoInternal(
base::trace_event::TracedValue* state) const override {}
- bool MaybeAdvanceTime() override { return false; }
+ base::Optional<base::TimeDelta> DelayTillNextTask(
+ LazyNow* lazy_now) override {
+ return base::Optional<base::TimeDelta>();
+ }
const char* GetName() const override { return "Test"; }
void OnRegisterWithTaskQueueManager(
TaskQueueManager* task_queue_manager) override {}
@@ -191,7 +194,7 @@ TEST_F(TimeDomainTest, UnregisterQueue) {
EXPECT_FALSE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
}
-TEST_F(TimeDomainTest, UpdateWorkQueues) {
+TEST_F(TimeDomainTest, WakeupReadyDelayedQueues) {
base::TimeDelta delay = base::TimeDelta::FromMilliseconds(50);
EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay));
base::TimeTicks now = time_domain_->Now();
@@ -203,13 +206,13 @@ TEST_F(TimeDomainTest, UpdateWorkQueues) {
EXPECT_EQ(delayed_runtime, next_run_time);
LazyNow lazy_now = time_domain_->CreateLazyNow();
- time_domain_->UpdateWorkQueues(lazy_now);
+ time_domain_->WakeupReadyDelayedQueues(&lazy_now);
ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time));
EXPECT_EQ(delayed_runtime, next_run_time);
time_domain_->SetNow(delayed_runtime);
lazy_now = time_domain_->CreateLazyNow();
- time_domain_->UpdateWorkQueues(lazy_now);
+ time_domain_->WakeupReadyDelayedQueues(&lazy_now);
ASSERT_FALSE(time_domain_->NextScheduledRunTime(&next_run_time));
}
@@ -235,7 +238,7 @@ class TimeDomainWithObserverTest : public TimeDomainTest {
TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) {
EXPECT_CALL(*observer_, OnTimeDomainHasImmediateWork(task_queue_.get()));
- time_domain_->RegisterAsUpdatableTaskQueue(task_queue_.get());
+ time_domain_->OnQueueHasImmediateWork(task_queue_.get());
}
TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) {

Powered by Google App Engine
This is Rietveld 408576698