cc/scheduler/begin_frame_source_unittest.cc - Issue 2546423002: [Try # 3] Scheduler refactoring to virtually eliminate redundant DoWorks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/scheduler/begin_frame_source_unittest.cc

Issue 2546423002: [Try # 3] Scheduler refactoring to virtually eliminate redundant DoWorks (Closed)

Patch Set: Added the MoveableAutoLock per Sami's suggestion Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/scheduler/begin_frame_source_unittest.cc

diff --git a/cc/scheduler/begin_frame_source_unittest.cc b/cc/scheduler/begin_frame_source_unittest.cc

index b50c4b91ce510a5444ba5912f090adca3dec176c..b29f1e10c1d50778d409325543e0bad1e29e4354 100644

--- a/cc/scheduler/begin_frame_source_unittest.cc

+++ b/cc/scheduler/begin_frame_source_unittest.cc

@@ -90,8 +90,8 @@ TEST_F(BackToBackBeginFrameSourceTest,

source_->DidFinishFrame(obs_.get(), 0);

source_->RemoveObserver(obs_.get());

- EXPECT_TRUE(task_runner_->HasPendingTasks());

- task_runner_->RunPendingTasks();

+ // There was a task posed but it's canceled.

Sami 2016/12/09 11:04:02 typo: posted

alex clarke (OOO till 29th) 2016/12/12 11:45:04 I found a way to remove this change.

+ EXPECT_FALSE(task_runner_->HasPendingTasks());

}

TEST_F(BackToBackBeginFrameSourceTest,