Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Issue 2546393002: Make setNeedsActiveStyleUpdate mark treescope dirty only. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp b/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
index 06a8129631ec454bb9090660d522cbdf78bc5917..f72cfd5292d9634b26b3d2297b66e1f6e38b6d6b 100644
--- a/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
@@ -218,13 +218,13 @@ void HTMLLinkElement::removedFrom(ContainerNode* insertionPoint) {
}
document().styleEngine().removeStyleSheetCandidateNode(*this);
- StyleSheet* removedSheet = sheet();
-
if (m_link)
m_link->ownerRemoved();
- document().styleEngine().setNeedsActiveStyleUpdate(removedSheet,
- FullStyleUpdate);
+ document().styleEngine().setNeedsActiveStyleUpdate(treeScope());
meade_UTC10 2016/12/05 23:57:22 It looks like the treeScope is not yet registered
rune 2016/12/06 14:53:22 It's the wrong treeScope(), we should have found t
+ // TODO(rune@opera.com): resolverChanged() can be removed once stylesheet
+ // updates are async. https://crbug.com/567021
+ document().styleEngine().resolverChanged(FullStyleUpdate);
}
void HTMLLinkElement::finishParsingChildren() {

Powered by Google App Engine
This is Rietveld 408576698