Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Issue 2546393002: Make setNeedsActiveStyleUpdate mark treescope dirty only. (Closed)
Patch Set: Rebased Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
6 * reserved. 6 * reserved.
7 * Copyright (C) 2009 Rob Buis (rwlbuis@gmail.com) 7 * Copyright (C) 2009 Rob Buis (rwlbuis@gmail.com)
8 * Copyright (C) 2011 Google Inc. All rights reserved. 8 * Copyright (C) 2011 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 212
213 m_linkLoader->released(); 213 m_linkLoader->released();
214 214
215 if (!wasConnected) { 215 if (!wasConnected) {
216 DCHECK(!linkStyle() || !linkStyle()->hasSheet()); 216 DCHECK(!linkStyle() || !linkStyle()->hasSheet());
217 return; 217 return;
218 } 218 }
219 document().styleEngine().removeStyleSheetCandidateNode(*this, 219 document().styleEngine().removeStyleSheetCandidateNode(*this,
220 *insertionPoint); 220 *insertionPoint);
221 221
222 StyleSheet* removedSheet = sheet();
223
224 if (m_link) 222 if (m_link)
225 m_link->ownerRemoved(); 223 m_link->ownerRemoved();
226 224
227 document().styleEngine().setNeedsActiveStyleUpdate(removedSheet, 225 // TODO(rune@opera.com): resolverChanged() can be removed once stylesheet
228 AnalyzedStyleUpdate); 226 // updates are async. https://crbug.com/567021
227 document().styleEngine().resolverChanged(AnalyzedStyleUpdate);
229 } 228 }
230 229
231 void HTMLLinkElement::finishParsingChildren() { 230 void HTMLLinkElement::finishParsingChildren() {
232 m_createdByParser = false; 231 m_createdByParser = false;
233 HTMLElement::finishParsingChildren(); 232 HTMLElement::finishParsingChildren();
234 } 233 }
235 234
236 bool HTMLLinkElement::styleSheetIsLoading() const { 235 bool HTMLLinkElement::styleSheetIsLoading() const {
237 return linkStyle() && linkStyle()->styleSheetIsLoading(); 236 return linkStyle() && linkStyle()->styleSheetIsLoading();
238 } 237 }
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 LinkLoaderClient::trace(visitor); 360 LinkLoaderClient::trace(visitor);
362 DOMTokenListObserver::trace(visitor); 361 DOMTokenListObserver::trace(visitor);
363 } 362 }
364 363
365 DEFINE_TRACE_WRAPPERS(HTMLLinkElement) { 364 DEFINE_TRACE_WRAPPERS(HTMLLinkElement) {
366 visitor->traceWrappers(m_relList); 365 visitor->traceWrappers(m_relList);
367 HTMLElement::traceWrappers(visitor); 366 HTMLElement::traceWrappers(visitor);
368 } 367 }
369 368
370 } // namespace blink 369 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/StyleEngine.cpp ('k') | third_party/WebKit/Source/core/html/HTMLStyleElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698