Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254633002: Start using the mediaControlsOverlayPlayButtonEnabled setting (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, adamk+blink_chromium.org, ojan, chrishtr, bemjb+rendering_chromium.org, dsinclair, rune+blink, dglazkov+blink, jchaffraix+rendering, pdr., rwlbuis, nessy, zoltan1, philipj_slow, feature-media-reviews_chromium.org, darktears, vcarbune.chromium, gasubic, leviw+renderwatch, ed+blinkwatch_opera.com
Visibility:
Public.

Description

Start using the mediaControlsOverlayPlayButtonEnabled setting BUG=366675 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M Source/core/css/mediaControls.css View 1 chunk +31 lines, -1 line 0 comments Download
M Source/core/css/mediaControlsAndroid.css View 2 chunks +0 lines, -30 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumAndroid.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderThemeChromiumSkia.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
philipj_slow
Patch 1: https://codereview.chromium.org/250533003/ Patch 2: https://codereview.chromium.org/257643002/ Patch 3: this
6 years, 8 months ago (2014-04-26 00:19:26 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-26 01:00:30 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-29 11:35:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/254633002/1
6 years, 7 months ago (2014-04-29 11:35:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 12:08:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-29 12:08:28 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-29 12:25:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/254633002/1
6 years, 7 months ago (2014-04-29 12:26:06 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 12:46:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-29 12:46:50 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-04-29 19:13:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/254633002/1
6 years, 7 months ago (2014-04-29 19:14:36 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 04:32:31 UTC) #13
Message was sent while issue was closed. 
Change committed as 172923

Powered by Google App Engine
This is Rietveld 408576698