Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2546253002: Remove isherman@ from Autofill OWNERS files (Closed)

Created:
4 years ago by Ilya Sherman
Modified:
4 years ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove isherman@ from Autofill OWNERS files BUG=none TEST=none R=mathp@chromium.org Committed: https://crrev.com/32d464be6c58c5d1f2ea48a4b27ff66cdbf360a4 Cr-Commit-Position: refs/heads/master@{#436292}

Patch Set 1 #

Patch Set 2 : libphonenumber too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/autofill/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/autofill/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M components/test/data/autofill/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libphonenumber/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Ilya Sherman
4 years ago (2016-12-03 00:07:37 UTC) #1
Ilya Sherman
Rachel, PTAL at the cocoa OWNERS change. Rouslan, PTAL at the libphonenumber OWNERS change.
4 years ago (2016-12-03 00:11:42 UTC) #4
Mathieu
On 2016/12/03 00:11:42, Ilya Sherman wrote: > Rachel, PTAL at the cocoa OWNERS change. > ...
4 years ago (2016-12-03 00:59:49 UTC) #5
groby-ooo-7-16
On 2016/12/03 00:59:49, Mathieu Perreault wrote: > On 2016/12/03 00:11:42, Ilya Sherman wrote: > > ...
4 years ago (2016-12-03 01:26:47 UTC) #6
please use gerrit instead
lgtm
4 years ago (2016-12-03 01:43:15 UTC) #7
vabr (Chromium)
Thanks, Ilya, for all the years of your code and review contributions to autofill! Cheers, ...
4 years ago (2016-12-05 09:37:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546253002/20001
4 years ago (2016-12-05 14:06:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 14:56:18 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 14:58:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32d464be6c58c5d1f2ea48a4b27ff66cdbf360a4
Cr-Commit-Position: refs/heads/master@{#436292}

Powered by Google App Engine
This is Rietveld 408576698