Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: src/typing.cc

Issue 254623002: Simplify feedback vector creation and store in SharedFunctionInfo. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: REBASE. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 3cca0f4261efb2be1962d8f77caecad16575226d..ba528fc6e8e367765d0370a07fc30a2ba3f96434 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -40,6 +40,7 @@ AstTyper::AstTyper(CompilationInfo* info)
: info_(info),
oracle_(
Handle<Code>(info->closure()->shared()->code()),
+ Handle<FixedArray>(info->closure()->shared()->feedback_vector()),
mvstanton 2014/04/30 08:31:18 Warning: you aren't copying the vector, what if a
Handle<Context>(info->closure()->context()->native_context()),
Benedikt Meurer 2014/04/28 19:17:00 Nit: Use handle() instead of Handle<T>()
mvstanton 2014/04/30 08:31:18 Done.
info->zone()),
store_(info->zone()) {
@@ -530,7 +531,7 @@ void AstTyper::VisitCall(Call* expr) {
// Collect type feedback.
RECURSE(Visit(expr->expression()));
if (!expr->expression()->IsProperty() &&
- expr->HasCallFeedbackSlot() &&
+ expr->IsUsingCallFeedbackSlot(isolate()) &&
oracle()->CallIsMonomorphic(expr->CallFeedbackSlot())) {
expr->set_target(oracle()->GetCallTarget(expr->CallFeedbackSlot()));
}

Powered by Google App Engine
This is Rietveld 408576698