Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/objects-debug.cc

Issue 254623002: Simplify feedback vector creation and store in SharedFunctionInfo. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Code comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 378
379 void PolymorphicCodeCache::PolymorphicCodeCacheVerify() { 379 void PolymorphicCodeCache::PolymorphicCodeCacheVerify() {
380 VerifyHeapPointer(cache()); 380 VerifyHeapPointer(cache());
381 CHECK(cache()->IsUndefined() || cache()->IsPolymorphicCodeCacheHashTable()); 381 CHECK(cache()->IsUndefined() || cache()->IsPolymorphicCodeCacheHashTable());
382 } 382 }
383 383
384 384
385 void TypeFeedbackInfo::TypeFeedbackInfoVerify() { 385 void TypeFeedbackInfo::TypeFeedbackInfoVerify() {
386 VerifyObjectField(kStorage1Offset); 386 VerifyObjectField(kStorage1Offset);
387 VerifyObjectField(kStorage2Offset); 387 VerifyObjectField(kStorage2Offset);
388 VerifyHeapPointer(feedback_vector());
389 } 388 }
390 389
391 390
392 void AliasedArgumentsEntry::AliasedArgumentsEntryVerify() { 391 void AliasedArgumentsEntry::AliasedArgumentsEntryVerify() {
393 VerifySmiField(kAliasedContextSlot); 392 VerifySmiField(kAliasedContextSlot);
394 } 393 }
395 394
396 395
397 void FixedArray::FixedArrayVerify() { 396 void FixedArray::FixedArrayVerify() {
398 for (int i = 0; i < length(); i++) { 397 for (int i = 0; i < length(); i++) {
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 next_function_link()->IsUndefined() || 558 next_function_link()->IsUndefined() ||
560 next_function_link()->IsJSFunction()); 559 next_function_link()->IsJSFunction());
561 } 560 }
562 561
563 562
564 void SharedFunctionInfo::SharedFunctionInfoVerify() { 563 void SharedFunctionInfo::SharedFunctionInfoVerify() {
565 CHECK(IsSharedFunctionInfo()); 564 CHECK(IsSharedFunctionInfo());
566 VerifyObjectField(kNameOffset); 565 VerifyObjectField(kNameOffset);
567 VerifyObjectField(kCodeOffset); 566 VerifyObjectField(kCodeOffset);
568 VerifyObjectField(kOptimizedCodeMapOffset); 567 VerifyObjectField(kOptimizedCodeMapOffset);
568 VerifyObjectField(kFeedbackVectorOffset);
569 VerifyObjectField(kScopeInfoOffset); 569 VerifyObjectField(kScopeInfoOffset);
570 VerifyObjectField(kInstanceClassNameOffset); 570 VerifyObjectField(kInstanceClassNameOffset);
571 VerifyObjectField(kFunctionDataOffset); 571 VerifyObjectField(kFunctionDataOffset);
572 VerifyObjectField(kScriptOffset); 572 VerifyObjectField(kScriptOffset);
573 VerifyObjectField(kDebugInfoOffset); 573 VerifyObjectField(kDebugInfoOffset);
574 } 574 }
575 575
576 576
577 void JSGlobalProxy::JSGlobalProxyVerify() { 577 void JSGlobalProxy::JSGlobalProxyVerify() {
578 CHECK(IsJSGlobalProxy()); 578 CHECK(IsJSGlobalProxy());
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
1229 for (int i = 0; i < number_of_transitions(); ++i) { 1229 for (int i = 0; i < number_of_transitions(); ++i) {
1230 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false; 1230 if (!CheckOneBackPointer(current_map, GetTarget(i))) return false;
1231 } 1231 }
1232 return true; 1232 return true;
1233 } 1233 }
1234 1234
1235 1235
1236 #endif // DEBUG 1236 #endif // DEBUG
1237 1237
1238 } } // namespace v8::internal 1238 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698