Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2546213002: Report analysis exceptions using the 'exceptions' stream or 'completeError'. (Closed)

Created:
4 years ago by scheglov
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report analysis exceptions using the 'exceptions' stream or 'completeError'. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c0ac1ca8f43f8e0efac75bde6f807012ed8655bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -40 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +13 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 8 chunks +100 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years ago (2016-12-02 21:52:49 UTC) #1
Brian Wilkerson
lgtm
4 years ago (2016-12-02 22:00:44 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as c0ac1ca8f43f8e0efac75bde6f807012ed8655bb (presubmit successful).
4 years ago (2016-12-02 22:22:46 UTC) #4
Paul Berry
4 years ago (2016-12-02 23:06:17 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698