Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2546193002: [ios] Matcher for a generic interstitial page. (Closed)

Created:
4 years ago by Eugene But (OOO till 7-30)
Modified:
4 years ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Matcher for a generic interstitial page. This matcher will be used to check that interstitial was dismissed after going back or proceeding. BUG=531721 Committed: https://crrev.com/f91c9f6d12a1c5626490c4ade31fb0490b619b84 Cr-Commit-Position: refs/heads/master@{#436104}

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M ios/web/public/test/earl_grey/web_view_matchers.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M ios/web/public/test/earl_grey/web_view_matchers.mm View 2 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
4 years ago (2016-12-02 20:57:46 UTC) #2
Jackie Quinn
lgtm
4 years ago (2016-12-03 00:35:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546193002/20001
4 years ago (2016-12-03 00:36:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-03 00:44:32 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-03 00:48:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f91c9f6d12a1c5626490c4ade31fb0490b619b84
Cr-Commit-Position: refs/heads/master@{#436104}

Powered by Google App Engine
This is Rietveld 408576698