Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2546173002: [ios] Adds downloads resources (Closed)

Created:
4 years ago by sczs1
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds downloads resources BUG=666732 Committed: https://crrev.com/be5168a2cccbacb7776c4c04cfa7a3798da55b71 Cr-Commit-Position: refs/heads/master@{#436016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -0 lines) Patch
A ios/chrome/browser/ui/downloads/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/Contents.json View 1 chunk +6 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/error_icon.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/error_icon.imageset/error_icon.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/error_icon.imageset/error_icon@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/error_icon.imageset/error_icon@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_body.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_body.imageset/file_icon_body.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_body.imageset/file_icon_body@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_body.imageset/file_icon_body@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold.imageset/file_icon_fold.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold.imageset/file_icon_fold@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold.imageset/file_icon_fold@3x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold_complete.imageset/Contents.json View 1 chunk +23 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold_complete.imageset/file_icon_fold_complete.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold_complete.imageset/file_icon_fold_complete@2x.png View Binary file 0 comments Download
A ios/chrome/browser/ui/downloads/resources/download_manager_assets.xcassets/file_icon_fold_complete.imageset/file_icon_fold_complete@3x.png View Binary file 0 comments Download

Messages

Total messages: 9 (4 generated)
sczs1
PTAL
4 years ago (2016-12-02 19:45:17 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-02 19:53:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546173002/1
4 years ago (2016-12-02 19:53:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 21:12:03 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-02 21:14:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be5168a2cccbacb7776c4c04cfa7a3798da55b71
Cr-Commit-Position: refs/heads/master@{#436016}

Powered by Google App Engine
This is Rietveld 408576698