Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: components/sync_sessions/sessions_sync_manager.h

Issue 2546163003: [Sync] Convert SyncSessions to NonUIDataTypeController and remove UIDataTypeController (Closed)
Patch Set: Fix SyncSessionsMetricsTest Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_sessions/sessions_sync_manager.h
diff --git a/components/sync_sessions/sessions_sync_manager.h b/components/sync_sessions/sessions_sync_manager.h
index 5585bbfdce73ccb60f99398658c91657cc662415..5f2b59813f78e32d7040c1b8fb96ece9e60aa36c 100644
--- a/components/sync_sessions/sessions_sync_manager.h
+++ b/components/sync_sessions/sessions_sync_manager.h
@@ -180,7 +180,7 @@ class SessionsSyncManager : public syncer::SyncableService,
ProcessRemoteDeleteOfLocalSession);
FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, SetVariationIds);
- void InitializeCurrentMachineTag();
+ void InitializeCurrentMachineTag(const std::string& cache_guid);
// Load and add window or tab data for a foreign session to our internal
// tracking.
@@ -299,9 +299,10 @@ class SessionsSyncManager : public syncer::SyncableService,
const syncer::SyncDataList& restored_tabs,
syncer::SyncChangeList* change_output);
- // Stops and re-starts syncing to rebuild association mappings.
+ // Stops and re-starts syncing to rebuild association mappings. Returns true
+ // when re-starting succeeds.
// See |local_tab_pool_out_of_sync_|.
- void RebuildAssociations();
+ bool RebuildAssociations();
// Validates the content of a SessionHeader protobuf.
// Returns false if validation fails.
@@ -351,8 +352,9 @@ class SessionsSyncManager : public syncer::SyncableService,
// Unique client tag.
std::string current_machine_tag_;
- // User-visible machine name.
+ // User-visible machine name and device type to populate header.
std::string current_session_name_;
+ sync_pb::SyncEnums::DeviceType current_device_type_;
// SyncID for the sync node containing all the window information for this
// client.
« no previous file with comments | « components/sync_sessions/session_data_type_controller.cc ('k') | components/sync_sessions/sessions_sync_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698