Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2546153002: Revert of Prerender: Hardcode the Silence experiment date (Closed)

Created:
4 years ago by pasko
Modified:
4 years ago
Reviewers:
droger, mattcary
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prerender: Hardcode the Silence experiment date (patchset #3 id:40001 of https://codereview.chromium.org/2538723003/ ) Reason for revert: too late to get it into M55 Original issue's description: > Prerender: Hardcode the Silence experiment date > > As confirmed with the UMA team, the field trial allows only 60-70% coverage of > users for one day (particularly, on Windows). > > To address this shortcoming, this change hardcodes the explicit date of the > experiment (for December 14th as seen in PST, to be synchronized with field > trial server-seeding better). To be effective this must be cherry-picked to M55. > > The experiment still has the ability to serve as a "kill switch" by setting the > group "ExperimentYes_expires_2016-12-14T07:00:00Z" (or any earlier date in the > string). As discussed above, this has limited effect in the day range. > > Also this changes AGSA to opt out of the experiment. Currently AGSA only uses > ORIGIN_EXTERNAL_REQUEST_FORCED_CELLULAR. The experiment will not take effect > on these origins. Other 1st party apps are not using this prerender::Origin, as > far as we know, and the use of it is restricted to 1st party, hence this change > should not affect the experiment for other Android apps. > > BUG=640592 > > Committed: https://crrev.com/40296583e81a52db397a24b2745f43a35ab6870e > Cr-Commit-Position: refs/heads/master@{#435610} TBR=droger@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=640592 Committed: https://crrev.com/ce619a3e844f0170c128162ba0f27d0a2bb685e2 Cr-Commit-Position: refs/heads/master@{#436002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -66 lines) Patch
M chrome/browser/prerender/prerender_manager.cc View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/prerender/prerender_unittest.cc View 2 chunks +12 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pasko
Created Revert of Prerender: Hardcode the Silence experiment date
4 years ago (2016-12-02 19:10:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546153002/1
4 years ago (2016-12-02 19:10:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 19:59:59 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 20:01:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce619a3e844f0170c128162ba0f27d0a2bb685e2
Cr-Commit-Position: refs/heads/master@{#436002}

Powered by Google App Engine
This is Rietveld 408576698