Chromium Code Reviews| Index: Source/devtools/protocol.json |
| diff --git a/Source/devtools/protocol.json b/Source/devtools/protocol.json |
| index 12f4e36669053b96e7bf0ed573378af5513d8174..d6f139a290aa7cbf24150de958e72e3488e147ca 100644 |
| --- a/Source/devtools/protocol.json |
| +++ b/Source/devtools/protocol.json |
| @@ -2762,10 +2762,7 @@ |
| "commands": [ |
| { |
| "name": "enable", |
| - "description": "Enables timeline. After this call, timeline can be started from within the page (for example upon console.timeline).", |
| - "parameters": [ |
| - { "name": "traceEventCategoryFilter", "optional": true, "type": "string", "description": "If set, the timeline agent will automatically start tracing with the specified category filter when timeline is started." } |
| - ] |
| + "description": "Enables timeline. After this call, timeline can be started from within the page (for example upon console.timeline)." |
| }, |
| { |
| "name": "disable", |
| @@ -4021,22 +4018,38 @@ |
| { |
| "name": "start", |
| "description": "Start trace events collection.", |
| - "async": true, |
| "parameters": [ |
| { "name": "categories", "type": "string", "description": "Category/tag filter" }, |
| { "name": "options", "type": "string", "description": "Tracing options" }, |
| { "name": "bufferUsageReportingInterval", "type": "number", "optional": true, "description": "If set, the agent will issue bufferUsage events at this interval, specified in milliseconds" } |
| ], |
| - "handlers": ["browser", "frontend"] |
| + "handlers": ["browser", "renderer", "frontend"] |
| }, |
| { |
| "name": "end", |
| "description": "Stop trace events collection.", |
| "handlers": ["browser", "frontend"] |
| + }, |
| + { |
| + "name": "enable", |
| + "description": "Enable the agent to be started from the inspected page, i.e. via a call to console.timeline(), and set default category filter.", |
| + "parameters": [ |
| + { "name": "categories", "type": "string", "description": "Category/tag filter used when tracing is enabled by the inspected page." } |
|
yurys
2014/04/24 14:08:09
We already pass categories in Tracing.start why re
|
| + ] |
| + }, |
| + { |
| + "name": "disable", |
| + "description": "Disable the agent to be started from the inspected page, i.e. via a call to console.timeline()." |
| } |
| ], |
| "events": [ |
| { |
| + "name": "pageTracingStarted", |
| + "parameters": [ |
| + { "name": "sessionId", "type": "string", "description": "A system-unique identifier of the tracing session that allows associating of some of the trace events with the inspected page" } |
|
yurys
2014/04/24 14:08:09
Can we send it in response to Tracing.start instea
|
| + ] |
| + }, |
| + { |
| "name": "dataCollected", |
| "parameters": [ |
| { "name": "value", "type": "array", "items": { "type": "object" } } |