Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2546123002: mus: Some more DEPS change. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Some more DEPS change. gpu code shouldn't know about surfaces/display-compositor (except for gpu-main which is responsible for setting everything up). And surfaces should not know about gpu code. The ws (or any other parts of mus) should know about either gpu or surfaces. BUG=none TBR=sky@ for services/ui/DEPS Committed: https://crrev.com/8cbbe0ffc3c5d96b3b912ef931c3cb29625e7643 Cr-Commit-Position: refs/heads/master@{#436165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M services/ui/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/gpu/DEPS View 1 chunk +8 lines, -1 line 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/surfaces/DEPS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
sadrul
4 years ago (2016-12-02 16:34:12 UTC) #4
Fady Samuel
Sweet! Thanks! LGTM
4 years ago (2016-12-02 16:38:27 UTC) #5
sadrul
+sky@ for services/ui/DEPS (will tbr)
4 years ago (2016-12-03 03:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546123002/1
4 years ago (2016-12-03 03:55:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-03 04:19:19 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8cbbe0ffc3c5d96b3b912ef931c3cb29625e7643 Cr-Commit-Position: refs/heads/master@{#436165}
4 years ago (2016-12-03 04:21:57 UTC) #17
sky
4 years ago (2016-12-03 16:30:37 UTC) #18
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698