Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2546113002: [turbofan] Improve memory consumption for state values descriptors. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve memory consumption for state values descriptors. Committed: https://crrev.com/09e4a11b25884fb8b3a8d16dd92512d49b6c771a Cr-Commit-Position: refs/heads/master@{#41469}

Patch Set 1 #

Patch Set 2 : Do not store optimized-out into instructions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -125 lines) Patch
M src/compiler/code-generator.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 4 chunks +46 lines, -52 lines 0 comments Download
M src/compiler/instruction.h View 1 3 chunks +94 lines, -26 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 3 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 7 chunks +25 lines, -27 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 2 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Jarin
Could you take a look, please?
4 years ago (2016-12-04 18:35:50 UTC) #4
Benedikt Meurer
Nice, LGTM.
4 years ago (2016-12-04 18:51:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546113002/20001
4 years ago (2016-12-04 19:23:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 06:33:36 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 06:34:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09e4a11b25884fb8b3a8d16dd92512d49b6c771a
Cr-Commit-Position: refs/heads/master@{#41469}

Powered by Google App Engine
This is Rietveld 408576698