Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 254603002: Remove lazy sweeping. (Closed)

Created:
6 years, 8 months ago by Hannes Payer (out of office)
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -163 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M src/incremental-marking.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mark-compact.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mark-compact.cc View 4 chunks +1 line, -23 lines 0 comments Download
M src/spaces.h View 5 chunks +12 lines, -26 lines 0 comments Download
M src/spaces.cc View 1 2 3 4 7 chunks +9 lines, -69 lines 0 comments Download
M src/store-buffer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 chunks +11 lines, -10 lines 0 comments Download
M test/mjsunit/regress/regress-1708.js View 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 8 months ago (2014-04-24 11:41:55 UTC) #1
Michael Starzinger
LGTM with one real issue and a couple of nits. https://codereview.chromium.org/254603002/diff/20001/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/254603002/diff/20001/src/spaces.cc#newcode2613 ...
6 years, 8 months ago (2014-04-25 07:57:14 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/254603002/diff/20001/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/254603002/diff/20001/src/spaces.cc#newcode2613 src/spaces.cc:2613: if (object != NULL) return object; On 2014/04/25 07:57:14, ...
6 years, 8 months ago (2014-04-25 09:40:53 UTC) #3
Hannes Payer (out of office)
6 years, 8 months ago (2014-04-25 09:51:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r20966 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698