Improve property under-invalidation DCHECKs in FindPropertiesNeedingUpdate

Improve property under-invalidation DCHECKs in FindPropertiesNeedingUpdate

The DCHECKs in FindPropertiesNeedingUpdate.h correctly find cases of
under-invalidation of paint properties, but the macro-based DCHECKs
are difficult to read or take action on. This patch updates
FindPropertiesNeedingUpdate to produce better DCHECK messages, as
well as updating comments to make these messages actionable.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/96606ec518ebf57313b7a9cb692905da3ee76b27
Cr-Commit-Position: refs/heads/master@{#435967}

[pdr., 2016-12-02 06:09:06]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, trchen@chromium.org, wangxianzhu@chromium.org

[pdr., 2016-12-02 06:09:32]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 06:09:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 08:30:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 08:30:19]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-12-02 16:46:22]

lgtm

[Xianzhu, 2016-12-02 17:35:59]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-02 17:36:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 17:40:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480700159023350, "parent_rev":
"cbdd4ec46f922f39f25017fb4bcabf9e7bd3f513", "commit_rev":
"301ea82507d1876b5609dad87aa60c6baabababe"}

[commit-bot: I haz the power, 2016-12-02 17:40:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-02 17:45:05]

Description was changed from

==========
Improve property under-invalidation DCHECKs in FindPropertiesNeedingUpdate

The DCHECKs in FindPropertiesNeedingUpdate.h correctly find cases of
under-invalidation of paint properties, but the macro-based DCHECKs
are difficult to read or take action on. This patch updates
FindPropertiesNeedingUpdate to produce better DCHECK messages, as
well as updating comments to make these messages actionable.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Improve property under-invalidation DCHECKs in FindPropertiesNeedingUpdate

The DCHECKs in FindPropertiesNeedingUpdate.h correctly find cases of
under-invalidation of paint properties, but the macro-based DCHECKs
are difficult to read or take action on. This patch updates
FindPropertiesNeedingUpdate to produce better DCHECK messages, as
well as updating comments to make these messages actionable.

BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/96606ec518ebf57313b7a9cb692905da3ee76b27
Cr-Commit-Position: refs/heads/master@{#435967}
==========

[commit-bot: I haz the power, 2016-12-02 17:45:06]

Patchset 1 (id:??) landed as
https://crrev.com/96606ec518ebf57313b7a9cb692905da3ee76b27
Cr-Commit-Position: refs/heads/master@{#435967}