Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2545973003: [Sync] Remove !frontend_ checks in SBHI. (Closed)

Created:
4 years ago by maxbogue
Modified:
4 years ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove !frontend_ checks in SBHI. All these functions are called from SyncBackendHostCore using a WeakHandle, and we invalidate WeakPtrs during shutdown before nulling out the frontend_ pointer, so they aren't necessary. BUG=669967 Committed: https://crrev.com/1bbc6856145b3e8e2984c9f7bef9261094e8fc9f Cr-Commit-Position: refs/heads/master@{#435955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M components/sync/driver/glue/sync_backend_host_impl.cc View 10 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
maxbogue
PTAL!
4 years ago (2016-12-02 16:45:56 UTC) #6
skym
lgtm
4 years ago (2016-12-02 16:47:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545973003/1
4 years ago (2016-12-02 16:48:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 16:52:12 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 16:55:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bbc6856145b3e8e2984c9f7bef9261094e8fc9f
Cr-Commit-Position: refs/heads/master@{#435955}

Powered by Google App Engine
This is Rietveld 408576698