Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2545963002: Set main frame id on DataUseRecorder created for render frame. (Closed)

Created:
4 years ago by Not at Google. Contact bengr
Modified:
4 years ago
Reviewers:
RyanSturm
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set main frame id on DataUseRecorder created for render frame. Without this id, there is no way to look this instance up in the render frame map. BUG=670257, 670240, 670438 Committed: https://crrev.com/c6d437f401a1b5053d7d1bf3aa2b13c99d854e70 Cr-Commit-Position: refs/heads/master@{#435797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Not at Google. Contact bengr
PTAL.
4 years ago (2016-12-01 23:50:39 UTC) #3
RyanSturm
lgtm.
4 years ago (2016-12-02 00:02:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545963002/1
4 years ago (2016-12-02 00:03:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 00:47:19 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-02 00:49:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6d437f401a1b5053d7d1bf3aa2b13c99d854e70
Cr-Commit-Position: refs/heads/master@{#435797}

Powered by Google App Engine
This is Rietveld 408576698