Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 2545953003: Don't include CachedUAStyle.h from StyleResolver.h (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include CachedUAStyle.h from StyleResolver.h Eliminates another 40+ compilation unit dependencies on ComputedStyle.h Committed: https://crrev.com/f557893e671d94ab50acef1a70b45fef4102e47d Cr-Commit-Position: refs/heads/master@{#435925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
mstensho (USE GERRIT)
4 years ago (2016-12-02 09:44:01 UTC) #4
fs
lgtm
4 years ago (2016-12-02 09:46:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545953003/1
4 years ago (2016-12-02 13:14:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 13:18:07 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 13:20:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f557893e671d94ab50acef1a70b45fef4102e47d
Cr-Commit-Position: refs/heads/master@{#435925}

Powered by Google App Engine
This is Rietveld 408576698