Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2545953002: Make concrete stream classes private to .cpp, part 3 (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
npm
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make concrete stream classes private to .cpp, part 3 Committed: https://pdfium.googlesource.com/pdfium/+/f78bf1a54a4afb6486869b4bc5850283225d7055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M xfa/fxfa/app/xfa_ffapp.cpp View 2 chunks +23 lines, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffapp_unittest.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/xfa_ffapp.h View 1 chunk +4 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Tom Sepez
NPM, nearing the end. Thanks.
4 years ago (2016-12-01 23:00:06 UTC) #5
npm
lgtm
4 years ago (2016-12-01 23:10:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545953002/1
4 years ago (2016-12-01 23:16:36 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 23:16:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f78bf1a54a4afb6486869b4bc5850283225d...

Powered by Google App Engine
This is Rietveld 408576698