Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: chrome/browser/predictors/resource_prefetch_common.h

Issue 2545943003: Accessing navigation information via webcontents (Closed)
Patch Set: Post-Review Modifications Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_common.h
diff --git a/chrome/browser/predictors/resource_prefetch_common.h b/chrome/browser/predictors/resource_prefetch_common.h
index 7dd2139bbb25e2b54d3b805954d8f6d416bccb6c..98549240e575bd55a1dc1f0a9b1f554abade1090 100644
--- a/chrome/browser/predictors/resource_prefetch_common.h
+++ b/chrome/browser/predictors/resource_prefetch_common.h
@@ -38,11 +38,11 @@ enum class PrefetchOrigin { NAVIGATION, EXTERNAL };
// Represents a single navigation for a render frame.
struct NavigationID {
NavigationID();
- NavigationID(int render_process_id,
ahemery 2016/12/06 14:31:12 This version was only used in test. Removed.
- int render_frame_id,
- const GURL& main_frame_url);
- NavigationID(const NavigationID& other);
explicit NavigationID(content::WebContents* web_contents);
+ explicit NavigationID(content::WebContents* web_contents,
ahemery 2016/12/06 14:31:12 New constructor, necessary to fully initialize the
Benoit L 2016/12/06 14:58:18 nit: Multiple parameters constructors don't need t
ahemery 2016/12/06 15:17:38 Removed explicit
+ const GURL& main_frame_url,
+ const base::TimeTicks& creation_time);
+ NavigationID(const NavigationID& other);
bool operator<(const NavigationID& rhs) const;
bool operator==(const NavigationID& rhs) const;

Powered by Google App Engine
This is Rietveld 408576698