Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor.h

Issue 2545943003: Accessing navigation information via webcontents (Closed)
Patch Set: Fixed SummarizeResponse Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/net/resource_prefetch_predictor_observer.cc ('K') | « chrome/browser/net/resource_prefetch_predictor_observer.cc ('k') | chrome/browser/predictors/resource_prefetch_predictor.cc » ('j') | chrome/browser/predictors/resource_prefetch_predictor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/predictors/resource_prefetch_predictor.h
diff --git a/chrome/browser/predictors/resource_prefetch_predictor.h b/chrome/browser/predictors/resource_prefetch_predictor.h
index d4a0065d57f8ec01a19b842eac69fa269d396235..93da024f45f14aa7f6ad63fd2e7d163a091a5c32 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor.h
+++ b/chrome/browser/predictors/resource_prefetch_predictor.h
@@ -96,7 +96,9 @@ class ResourcePrefetchPredictor
bool always_revalidate;
// Initializes a |URLRequestSummary| from a |URLRequest| response.
- // Returns true for success.
+ // Returns true for success. Note: Navigation ID has particular
alexilin 2016/12/05 13:20:00 nit: Note: NavigationID is not initialized by this
Benoit L 2016/12/05 13:25:56 Thanks for documenting this.
+ // constraints and is NOT initialized by this function. See Observer
+ // private method RetriveNavigationID
static bool SummarizeResponse(const net::URLRequest& request,
URLRequestSummary* summary);
};
« chrome/browser/net/resource_prefetch_predictor_observer.cc ('K') | « chrome/browser/net/resource_prefetch_predictor_observer.cc ('k') | chrome/browser/predictors/resource_prefetch_predictor.cc » ('j') | chrome/browser/predictors/resource_prefetch_predictor.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698