Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2181)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor_unittest.cc

Issue 2545943003: Accessing navigation information via webcontents (Closed)
Patch Set: Post-Review Modifications #3 Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
index bf1e16092a4558a1f713c3a90582ebee9a49289d..62b0effd5b40191a104621912144fec79fcc0684 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor_unittest.cc
@@ -1324,14 +1324,16 @@ TEST_F(ResourcePrefetchPredictorTest, SummarizeResponse) {
url, net::MEDIUM, content::RESOURCE_TYPE_IMAGE, 1, 1, true);
URLRequestSummary summary;
EXPECT_TRUE(URLRequestSummary::SummarizeResponse(*request, &summary));
- EXPECT_EQ(1, summary.navigation_id.render_process_id);
- EXPECT_EQ(1, summary.navigation_id.render_frame_id);
- EXPECT_EQ(url, summary.navigation_id.main_frame_url);
EXPECT_EQ(url, summary.resource_url);
EXPECT_EQ(content::RESOURCE_TYPE_IMAGE, summary.resource_type);
EXPECT_TRUE(summary.was_cached);
EXPECT_FALSE(summary.has_validators);
EXPECT_FALSE(summary.always_revalidate);
+
+ // Navigation_id elements should be unset by default.
+ EXPECT_EQ(-1, summary.navigation_id.render_process_id);
+ EXPECT_EQ(-1, summary.navigation_id.render_frame_id);
+ EXPECT_EQ(GURL(), summary.navigation_id.main_frame_url);
}
TEST_F(ResourcePrefetchPredictorTest, SummarizeResponseContentType) {

Powered by Google App Engine
This is Rietveld 408576698