Accessing navigation information via webcontents

chrome/browser/predictors/resource_prefetcher_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/predictors/resource_prefetcher.h"
 
 #include <stddef.h>
 
 #include <memory>
+#include <string>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
+#include "chrome/browser/predictors/resource_prefetch_predictor_test_util.h"
 #include "chrome/browser/predictors/resource_prefetcher_manager.h"
 #include "chrome/test/base/testing_profile.h"
 #include "content/public/test/test_browser_thread.h"
 #include "net/base/load_flags.h"
 #include "net/url_request/redirect_info.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 118 matching lines @@
       io_thread_(content::BrowserThread::IO, &loop_),
       prefetcher_delegate_(&loop_) {
   config_.max_prefetches_inflight_per_navigation = 5;
   config_.max_prefetches_inflight_per_host_per_navigation = 2;
 }
 
 ResourcePrefetcherTest::~ResourcePrefetcherTest() {
 }
 
 TEST_F(ResourcePrefetcherTest, TestPrefetcherFinishes) {
-  GURL main_frame_url("http://www.google.com");
+  std::string main_frame_url_string("http://www.google.com");
+  GURL main_frame_url(main_frame_url_string);

[Benoit L, 2016/12/06 14:58:18]

nit: You can use main_frame_url.spec() to avoid adding the string.

[ahemery, 2016/12/06 15:17:38]

Simplified

   std::vector<GURL> urls = {GURL("http://www.google.com/resource1.html"),
                             GURL("http://www.google.com/resource2.png"),
                             GURL("http://yahoo.com/resource1.png"),
                             GURL("http://yahoo.com/resource2.png"),
                             GURL("http://yahoo.com/resource3.png"),
                             GURL("http://m.google.com/resource1.jpg"),
                             GURL("http://www.google.com/resource3.html"),
                             GURL("http://m.google.com/resource2.html"),
                             GURL("http://m.google.com/resource3.css"),
                             GURL("http://m.google.com/resource4.png"),
                             GURL("http://yahoo.com/resource4.png"),
                             GURL("http://yahoo.com/resource5.png")};
 
-  NavigationID navigation_id(1, 2, main_frame_url);
+  NavigationID navigation_id = CreateNavigationID(1, 2, main_frame_url_string);
 
   prefetcher_.reset(new TestResourcePrefetcher(&prefetcher_delegate_, config_,
                                                main_frame_url, urls));
 
   // Starting the prefetcher maxes out the number of possible requests.
   AddStartUrlRequestExpectation("http://www.google.com/resource1.html");
   AddStartUrlRequestExpectation("http://www.google.com/resource2.png");
   AddStartUrlRequestExpectation("http://yahoo.com/resource1.png");
   AddStartUrlRequestExpectation("http://yahoo.com/resource2.png");
   AddStartUrlRequestExpectation("http://m.google.com/resource1.jpg");
@@ skipping 43 matching lines @@
 
   // Expect the final call.
   EXPECT_CALL(prefetcher_delegate_,
               ResourcePrefetcherFinished(Eq(prefetcher_.get())));
 
   OnResponse("http://yahoo.com/resource3.png");
   CheckPrefetcherState(0, 0, 0);
 }
 
 TEST_F(ResourcePrefetcherTest, TestPrefetcherStopped) {
-  GURL main_frame_url("http://www.google.com");
+  std::string main_frame_url_string("http://www.google.com");

[Benoit L, 2016/12/06 14:58:18]

nit: ditto.

+  GURL main_frame_url(main_frame_url_string);
   std::vector<GURL> urls = {GURL("http://www.google.com/resource1.html"),
                             GURL("http://www.google.com/resource2.png"),
                             GURL("http://yahoo.com/resource1.png"),
                             GURL("http://yahoo.com/resource2.png"),
                             GURL("http://yahoo.com/resource3.png"),
                             GURL("http://m.google.com/resource1.jpg")};
 
-  NavigationID navigation_id(1, 2, main_frame_url);
+  NavigationID navigation_id = CreateNavigationID(1, 2, main_frame_url_string);
 
   prefetcher_.reset(new TestResourcePrefetcher(&prefetcher_delegate_, config_,
                                                main_frame_url, urls));
 
   // Starting the prefetcher maxes out the number of possible requests.
   AddStartUrlRequestExpectation("http://www.google.com/resource1.html");
   AddStartUrlRequestExpectation("http://www.google.com/resource2.png");
   AddStartUrlRequestExpectation("http://yahoo.com/resource1.png");
   AddStartUrlRequestExpectation("http://yahoo.com/resource2.png");
   AddStartUrlRequestExpectation("http://m.google.com/resource1.jpg");
@@ skipping 17 matching lines @@
 
   // Expect the final call.
   EXPECT_CALL(prefetcher_delegate_,
               ResourcePrefetcherFinished(Eq(prefetcher_.get())));
 
   OnResponse("http://m.google.com/resource1.jpg");
   CheckPrefetcherState(0, 1, 0);
 }
 
 }  // namespace predictors