Removing the .stripped suffix from minidumps produced by crashpad.

telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import glob
 import heapq
 import logging
 import os
 import os.path
@@ skipping 475 matching lines @@
       return output[info_start:info_end]
 
     arch_name = self.browser.platform.GetArchName()
     stackwalk = binary_manager.FetchPath(
         'minidump_stackwalk', arch_name, os_name)
     if not stackwalk:
       logging.warning('minidump_stackwalk binary not found.')
       return None
 
     with open(minidump, 'rb') as infile:
-      minidump += '.stripped'
+      if os_name != 'mac':
+        minidump += '.stripped'
       with open(minidump, 'wb') as outfile:
         outfile.write(''.join(infile.read().partition('MDMP')[1:]))

[Ken Russell (switch to Gerrit), 2016/12/01 22:43:04]

Per mark's comment in
https://bugs.chromium.org/p/chromium/issues/detail?id=667475#c12 , I really
think we should just delete this entire block of logic.

[eyaich1, 2016/12/01 23:13:00]

Done.

 
     symbols_path = os.path.join(self._tmp_minidump_dir, 'symbols')
     GenerateBreakpadSymbols(minidump, arch_name, os_name,
                             symbols_path, self._browser_directory)
 
     return subprocess.check_output([stackwalk, minidump, symbols_path],
                                    stderr=open(os.devnull, 'w'))
 
   def _UploadMinidumpToCloudStorage(self, minidump_path):
     """ Upload minidump_path to cloud storage and return the cloud storage url.
@@ skipping 20 matching lines @@
       return (False, 'No crash dump found.')
     logging.info('Minidump found: %s' % most_recent_dump)
     return self._InternalSymbolizeMinidump(most_recent_dump)
 
   def GetMostRecentMinidumpPath(self):
     return self._GetMostRecentMinidump()
 
   def GetAllMinidumpPaths(self):
     reports_list = self._GetAllCrashpadMinidumps()
     if reports_list:
       return [report[1] for report in reports_list]

[Mark Mentovai, 2016/12/01 22:46:56]

Here is where you know you’ve gotten minidumps from Crashpad.

[eyaich1, 2016/12/01 23:13:00]

Acknowledged.

     else:
       logging.info('No minidump found via crashpad_database_util')
       dumps = self._GetBreakPadMinidumpPaths()
       if dumps:
         logging.info('Found minidump via globbing in minidump dir')
         return dumps
       return []
 
   def GetAllUnsymbolizedMinidumpPaths(self):
     minidump_paths = set(self.GetAllMinidumpPaths())
@@ skipping 72 matching lines @@
         shutil.rmtree(self._tmp_profile_dir, ignore_errors=True)
         self._tmp_profile_dir = None
 
     if self._tmp_output_file:
       self._tmp_output_file.close()
       self._tmp_output_file = None
 
     if self._tmp_minidump_dir:
       shutil.rmtree(self._tmp_minidump_dir, ignore_errors=True)
       self._tmp_minidump_dir = None