Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: src/objects.cc

Issue 254593002: Reland r20932: "*NumberDictionary::AtNumberPut() handlified." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: The fix Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 16046 matching lines...) Expand 10 before | Expand all | Expand 10 after
16057 uint32_t key, 16057 uint32_t key,
16058 Handle<Object> value) { 16058 Handle<Object> value) {
16059 SLOW_ASSERT(dictionary->FindEntry(key) == kNotFound); 16059 SLOW_ASSERT(dictionary->FindEntry(key) == kNotFound);
16060 CALL_HEAP_FUNCTION(dictionary->GetIsolate(), 16060 CALL_HEAP_FUNCTION(dictionary->GetIsolate(),
16061 dictionary->Add( 16061 dictionary->Add(
16062 key, *value, PropertyDetails(NONE, NORMAL, 0)), 16062 key, *value, PropertyDetails(NONE, NORMAL, 0)),
16063 UnseededNumberDictionary); 16063 UnseededNumberDictionary);
16064 } 16064 }
16065 16065
16066 16066
16067 MaybeObject* SeededNumberDictionary::AtNumberPut(uint32_t key, Object* value) { 16067 Handle<SeededNumberDictionary> SeededNumberDictionary::AtNumberPut(
16068 UpdateMaxNumberKey(key); 16068 Handle<SeededNumberDictionary> dictionary,
16069 return AtPut(key, value); 16069 uint32_t key,
16070 Handle<Object> value) {
16071 dictionary->UpdateMaxNumberKey(key);
16072 CALL_HEAP_FUNCTION(
16073 dictionary->GetIsolate(),
16074 dictionary->AtPut(key, *value),
16075 SeededNumberDictionary);
16070 } 16076 }
16071 16077
16072 16078
16073 MaybeObject* UnseededNumberDictionary::AtNumberPut(uint32_t key, 16079 Handle<UnseededNumberDictionary> UnseededNumberDictionary::AtNumberPut(
16074 Object* value) { 16080 Handle<UnseededNumberDictionary> dictionary,
16075 return AtPut(key, value); 16081 uint32_t key,
16082 Handle<Object> value) {
16083 CALL_HEAP_FUNCTION(
16084 dictionary->GetIsolate(),
16085 dictionary->AtPut(key, *value),
16086 UnseededNumberDictionary);
16076 } 16087 }
16077 16088
16078 16089
16079 Handle<SeededNumberDictionary> SeededNumberDictionary::Set( 16090 Handle<SeededNumberDictionary> SeededNumberDictionary::Set(
16080 Handle<SeededNumberDictionary> dictionary, 16091 Handle<SeededNumberDictionary> dictionary,
16081 uint32_t key, 16092 uint32_t key,
16082 Handle<Object> value, 16093 Handle<Object> value,
16083 PropertyDetails details) { 16094 PropertyDetails details) {
16084 int entry = dictionary->FindEntry(key); 16095 int entry = dictionary->FindEntry(key);
16085 if (entry == kNotFound) { 16096 if (entry == kNotFound) {
(...skipping 1328 matching lines...) Expand 10 before | Expand all | Expand 10 after
17414 #define ERROR_MESSAGES_TEXTS(C, T) T, 17425 #define ERROR_MESSAGES_TEXTS(C, T) T,
17415 static const char* error_messages_[] = { 17426 static const char* error_messages_[] = {
17416 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 17427 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
17417 }; 17428 };
17418 #undef ERROR_MESSAGES_TEXTS 17429 #undef ERROR_MESSAGES_TEXTS
17419 return error_messages_[reason]; 17430 return error_messages_[reason];
17420 } 17431 }
17421 17432
17422 17433
17423 } } // namespace v8::internal 17434 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.h ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698