chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc - Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

Issue 2545923004: Remove LauncherItemController::type; use ShelfItems::type. (Closed)

Patch Set: Update tests; fix test item running status. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc ('K') | « chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h ('k') | chrome/browser/ui/ash/launcher/launcher_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

index bcbcf320bddc48fe0f10f51650e0aa6d37790a05..c8eab787d2c843a601cee9462b9d10dbf9429b9e 100644

--- a/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

+++ b/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc

@@ -50,13 +50,10 @@ gfx::Image GetAppListIcon(extensions::AppWindow* app_window) {

ExtensionAppWindowLauncherItemController::

ExtensionAppWindowLauncherItemController(

- Type type,

const std::string& app_id,

const std::string& launch_id,

ChromeLauncherController* controller)

- : AppWindowLauncherItemController(type, app_id, launch_id, controller) {

- DCHECK_NE(TYPE_APP_PANEL, type);

+ : AppWindowLauncherItemController(app_id, launch_id, controller) {}

ExtensionAppWindowLauncherItemController::

~ExtensionAppWindowLauncherItemController() {}