Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: pkg/dev_compiler/lib/js/legacy/dart_sdk.js

Issue 2545923002: Keep only a single active stack trace, enables traces for thrown non-exceptions (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: pkg/dev_compiler/lib/js/legacy/dart_sdk.js
diff --git a/pkg/dev_compiler/lib/js/legacy/dart_sdk.js b/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
index 34888fddba675928ed3f21dce9844e03a42a5b85..9dd23d8c8e700b8d30a6518d7f02d4c3d02c4c4b 100644
--- a/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
+++ b/pkg/dev_compiler/lib/js/legacy/dart_sdk.js
@@ -1900,14 +1900,12 @@ dart_library.library('dart_sdk', null, /* Imports */[
if (!condition) dart.throwAssertionError();
};
dart.throw = function(obj) {
- if (obj != null && (typeof obj == 'object' || typeof obj == 'function')) {
- dart._stack.set(obj, new Error());
- }
+ dart._stack = new Error();
throw obj;
};
dart.getError = function(exception) {
- var stack = dart._stack.get(exception);
- return stack !== void 0 ? stack : exception;
+ var stack = dart._stack;
+ return stack !== null ? stack : exception;
};
dart.stackPrint = function(exception) {
var error = dart.getError(exception);
@@ -2665,7 +2663,7 @@ dart_library.library('dart_sdk', null, /* Imports */[
return false;
});
})();
- dart._stack = new WeakMap();
+ dart._stack = null;
dart._value = Symbol("_value");
dart.constants = new Map();
dart.constantLists = new Map();

Powered by Google App Engine
This is Rietveld 408576698