Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2545893003: Remove RefPtr<ScriptState> from MediaSession (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
Yuki
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RefPtr<ScriptState> from MediaSession RefPtr<ScriptState> stored in DOM objects has a risk of leaking ScriptStates to unexpected worlds. We should explicitly pass in ScriptState when we need it. This CL makes MediaSession a ContextLifecycleObserver. BUG=669812 Committed: https://crrev.com/a1229b7ad6ec062281bcd389dcc1ca93b49f5d2f Cr-Commit-Position: refs/heads/master@{#436853}

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Patch Set 4 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M third_party/WebKit/Source/modules/mediasession/MediaSession.h View 2 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.cpp View 1 2 3 7 chunks +14 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
haraken
PTAL
4 years ago (2016-12-02 07:23:44 UTC) #2
haraken
As far as I grep, I think this is the final CL to remove RefPtr<ScriptState> ...
4 years ago (2016-12-02 07:30:04 UTC) #3
Yuki
lgtm
4 years ago (2016-12-02 07:45:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545893003/40001
4 years ago (2016-12-02 07:46:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/346651)
4 years ago (2016-12-02 09:37:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545893003/60001
4 years ago (2016-12-06 05:59:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/80057)
4 years ago (2016-12-06 06:45:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545893003/60001
4 years ago (2016-12-07 02:11:51 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-07 03:43:15 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-07 03:47:11 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a1229b7ad6ec062281bcd389dcc1ca93b49f5d2f
Cr-Commit-Position: refs/heads/master@{#436853}

Powered by Google App Engine
This is Rietveld 408576698