Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2545883005: DevTools: support sourceMappingURL for the inline stylesheets (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: support sourceMappingURL for the inline stylesheets This patch properly linkifies inline stylesheet URLs if they have attached sourcemap. BUG=649679 R=dgozman Committed: https://crrev.com/67acf0bd70e456cf893140802c1eda5813ab33c5 Cr-Commit-Position: refs/heads/master@{#436416}

Patch Set 1 #

Patch Set 2 : fix sourcemap for inline style #

Total comments: 4

Patch Set 3 : address comments #

Messages

Total messages: 14 (8 generated)
lushnikov
please, take a look
4 years ago (2016-12-03 00:26:04 UTC) #1
dgozman
Nice one! lgtm https://codereview.chromium.org/2545883005/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2545883005/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode631 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:631: this.navigable = !!rule.resourceURL() || hasSourceMap; Note: ...
4 years ago (2016-12-04 03:13:14 UTC) #6
lushnikov
Thanks! https://codereview.chromium.org/2545883005/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js (right): https://codereview.chromium.org/2545883005/diff/20001/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js#newcode631 third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:631: this.navigable = !!rule.resourceURL() || hasSourceMap; On 2016/12/04 03:13:13, ...
4 years ago (2016-12-05 19:56:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545883005/40001
4 years ago (2016-12-05 19:57:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 21:35:27 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-05 21:37:55 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/67acf0bd70e456cf893140802c1eda5813ab33c5
Cr-Commit-Position: refs/heads/master@{#436416}

Powered by Google App Engine
This is Rietveld 408576698