Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2545873002: Remove TrayIMETest valgrind suppression (Closed)

Created:
4 years ago by James Cook
Modified:
4 years ago
Reviewers:
sadrul
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TrayIMETest valgrind suppression The underlying crash bug was fixed long ago. BUG=545533 TEST=memory bots Committed: https://crrev.com/d3550666767344584b74439978e464c7cf6ae5c7 Cr-Commit-Position: refs/heads/master@{#435844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
James Cook
sadrul, please take a look.
4 years ago (2016-12-01 19:19:40 UTC) #2
sadrul
lgtm
4 years ago (2016-12-02 00:56:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545873002/1
4 years ago (2016-12-02 03:29:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 03:34:08 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-02 03:38:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3550666767344584b74439978e464c7cf6ae5c7
Cr-Commit-Position: refs/heads/master@{#435844}

Powered by Google App Engine
This is Rietveld 408576698