Issue 2545843002: Modify dev_compiler to use analyzer's new AstFactory class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2545843002: Modify dev_compiler to use analyzer's new AstFactory class. (Closed)

Created:
4 years ago by Paul Berry

Modified:
4 years ago

Reviewers:
vsm, Jennifer Messerly

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Modify dev_compiler to use analyzer's new AstFactory class. The old mechanism for creating analyzer ASTs (factory constructors on the interface classes) will be going away in analyzer 0.30. R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/2d289c2df63f690d1c001976c953fdc951dafed1

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -51 lines)			Patch
M	pkg/dev_compiler/lib/src/compiler/ast_builder.dart	View	1	8 chunks	+46 lines, -42 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/code_generator.dart	View	1	6 chunks	+9 lines, -8 lines	0 comments	Download
M	pkg/dev_compiler/lib/src/compiler/reify_coercions.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years ago (2016-12-01 18:37:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
2d289c2df63f690d1c001976c953fdc951dafed1 (presubmit successful).