Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 254583004: Fix incorrect bitmask check. (Closed)

Created:
6 years, 8 months ago by Nico
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix incorrect bitmask check. clang says: ..\..\chrome\browser\ui\views\frame\minimize_button_metrics_win.cc(24,59) : warning(clang): use of logical '||' with constant operand [-Wconstant-logical-operand] (titlebar_info.rgstate[2] & (STATE_SYSTEM_INVISIBLE || ^ ..\..\chrome\browser\ui\views\frame\minimize_button_metrics_win.cc(24,59) : note(clang): use '|' for a bitwise operation (titlebar_info.rgstate[2] & (STATE_SYSTEM_INVISIBLE || ^~ | 1 warning generated. BUG=82385 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/minimize_button_metrics_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
Since this code so far was never executed, is it needed? Is the right fix ...
6 years, 8 months ago (2014-04-24 20:38:11 UTC) #1
sky
LGTM
6 years, 8 months ago (2014-04-24 20:42:11 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 8 months ago (2014-04-24 20:44:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/254583004/1
6 years, 8 months ago (2014-04-24 21:16:09 UTC) #4
cjhopman
On 2014/04/24 20:38:11, Nico wrote: > Since this code so far was never executed, is ...
6 years, 8 months ago (2014-04-24 21:41:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 22:46:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-24 22:46:53 UTC) #7
Nico
6 years, 8 months ago (2014-04-24 23:11:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r266028 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698