Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2545823002: Store the NSEvent.description in a crash key in -[BrowserCrApplication sendEvent:]. (Closed)

Created:
4 years ago by Robert Sesek
Modified:
4 years ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store the NSEvent.description in a crash key in -[BrowserCrApplication sendEvent:]. BUG=520706 R=erikchen@chromium.org Committed: https://crrev.com/00a60ff6cc93a14db977a4b73c4f2b287e2a09b0 Cr-Commit-Position: refs/heads/master@{#435630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Robert Sesek
4 years ago (2016-12-01 16:12:20 UTC) #3
erikchen
lgtm
4 years ago (2016-12-01 16:16:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545823002/1
4 years ago (2016-12-01 17:00:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 17:05:42 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 17:07:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00a60ff6cc93a14db977a4b73c4f2b287e2a09b0
Cr-Commit-Position: refs/heads/master@{#435630}

Powered by Google App Engine
This is Rietveld 408576698