third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js - Issue 2545813003: [DevTools] fix minor issue with inline breakpoints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2545813003: [DevTools] fix minor issue with inline breakpoints (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

index 628f2ab47b7b24218a0dbb9c3052418c9ed78755..5d716f8aa3bf801db7972107d798d866055de434 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

@@ -794,7 +794,7 @@ Sources.JavaScriptSourceFrame = class extends Sources.UISourceCodeFrame {

new Set(decorations.map(decoration => decoration.bookmark).filter(bookmark => !!bookmark));

var lineEnd = this._textEditor.line(lineNumber).length;

var bookmarks = this._textEditor.bookmarks(

- new Common.TextRange(lineNumber, 0, lineEnd, 0),

+ new Common.TextRange(lineNumber, 0, lineNumber, lineEnd),

Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol);

for (var bookmark of bookmarks) {

if (!actualBookmarks.has(bookmark))