Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js

Issue 2545813003: [DevTools] fix minor issue with inline breakpoints (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
index b0f0bf1eb283ddc53f51a0a4588ea613267cd978..c2dd0ba8608f978d19722018abea22380a2edd9b 100644
--- a/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
@@ -689,16 +689,18 @@ InspectorTest.dumpJavaScriptSourceFrameBreakpoints = function(sourceFrame)
var disabled = textEditor.hasLineClass(lineNumber, "cm-breakpoint-disabled");
var conditional = textEditor.hasLineClass(lineNumber, "cm-breakpoint-conditional")
InspectorTest.addResult("breakpoint at " + lineNumber + (disabled ? " disabled" : "") + (conditional ? " conditional" : ""));
- }
- var bookmarks = textEditor.bookmarks(textEditor.fullRange(), Sources.JavaScriptSourceFrame.BreakpointDecoration._bookmarkSymbol);
- bookmarks = bookmarks.filter(bookmark => !!bookmark.position());
- bookmarks.sort((bookmark1, bookmark2) => bookmark1.position().startColumn - bookmark2.position().startColumn);
- for (var bookmark of bookmarks) {
- var position = bookmark.position();
- var element = bookmark[Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest];
- var disabled = element.classList.contains("cm-inline-disabled");
- var conditional = element.classList.contains("cm-inline-conditional");
- InspectorTest.addResult(" inline breakpoint at (" + position.startLine + ", " + position.startColumn + ")" + (disabled ? " disabled" : "") + (conditional ? " conditional" : ""));
+
+ var range = new Common.TextRange(lineNumber, 0, lineNumber, textEditor.line(lineNumber).length);
+ var bookmarks = textEditor.bookmarks(range, Sources.JavaScriptSourceFrame.BreakpointDecoration._bookmarkSymbol);
+ bookmarks = bookmarks.filter(bookmark => !!bookmark.position());
+ bookmarks.sort((bookmark1, bookmark2) => bookmark1.position().startColumn - bookmark2.position().startColumn);
+ for (var bookmark of bookmarks) {
+ var position = bookmark.position();
+ var element = bookmark[Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest];
+ var disabled = element.classList.contains("cm-inline-disabled");
+ var conditional = element.classList.contains("cm-inline-conditional");
+ InspectorTest.addResult(" inline breakpoint at (" + position.startLine + ", " + position.startColumn + ")" + (disabled ? " disabled" : "") + (conditional ? " conditional" : ""));
+ }
}
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/sources/debugger/source-frame-inline-breakpoint-decorations.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698