Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2545813003: [DevTools] fix minor issue with inline breakpoints (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 for (var lineNumber of lineNumbers) { 787 for (var lineNumber of lineNumbers) {
788 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint', false); 788 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint', false);
789 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint-disabled', fa lse); 789 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint-disabled', fa lse);
790 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint-conditional', false); 790 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint-conditional', false);
791 791
792 var decorations = this._lineBreakpointDecorations(lineNumber); 792 var decorations = this._lineBreakpointDecorations(lineNumber);
793 var actualBookmarks = 793 var actualBookmarks =
794 new Set(decorations.map(decoration => decoration.bookmark).filter(bo okmark => !!bookmark)); 794 new Set(decorations.map(decoration => decoration.bookmark).filter(bo okmark => !!bookmark));
795 var lineEnd = this._textEditor.line(lineNumber).length; 795 var lineEnd = this._textEditor.line(lineNumber).length;
796 var bookmarks = this._textEditor.bookmarks( 796 var bookmarks = this._textEditor.bookmarks(
797 new Common.TextRange(lineNumber, 0, lineEnd, 0), 797 new Common.TextRange(lineNumber, 0, lineNumber, lineEnd),
798 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol); 798 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol);
799 for (var bookmark of bookmarks) { 799 for (var bookmark of bookmarks) {
800 if (!actualBookmarks.has(bookmark)) 800 if (!actualBookmarks.has(bookmark))
801 bookmark.clear(); 801 bookmark.clear();
802 } 802 }
803 if (!decorations.length) 803 if (!decorations.length)
804 continue; 804 continue;
805 decorations.sort(Sources.JavaScriptSourceFrame.BreakpointDecoration.most SpecificFirst); 805 decorations.sort(Sources.JavaScriptSourceFrame.BreakpointDecoration.most SpecificFirst);
806 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint', true); 806 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint', true);
807 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint-disabled', !d ecorations[0].enabled || this._muted); 807 this.textEditor.toggleLineClass(lineNumber, 'cm-breakpoint-disabled', !d ecorations[0].enabled || this._muted);
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
1322 if (!this.bookmark) 1322 if (!this.bookmark)
1323 return; 1323 return;
1324 this.bookmark.clear(); 1324 this.bookmark.clear();
1325 this.bookmark = null; 1325 this.bookmark = null;
1326 } 1326 }
1327 }; 1327 };
1328 1328
1329 Sources.JavaScriptSourceFrame.BreakpointDecoration._decorationSymbol = Symbol('d ecoration'); 1329 Sources.JavaScriptSourceFrame.BreakpointDecoration._decorationSymbol = Symbol('d ecoration');
1330 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); 1330 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark');
1331 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); 1331 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element');
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger/source-frame-inline-breakpoint-decorations-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698