Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 25458002: Migrate to Styx thumbnails in Files App. (Closed)

Created:
7 years, 2 months ago by mtomasz
Modified:
7 years, 2 months ago
Reviewers:
yoshiki, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Migrate to Styx thumbnails in Files App. Styx provides thumbnails using a persistent urls, in contrast to the previous urls which used to get stale with time. This patch moves to the persisten urls, to there is no need to handle stale urls anymore. TEST=browser_tests BUG=254025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226362

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 1

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -24 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/image_loader/manifest.json View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/image_loader/request.js View 1 2 3 chunks +107 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@yoshiki: PTAL at *.js. @kinaba: PTAL at *.cc. The thumbnailUrl is created in private_api_drive.cc, however ...
7 years, 2 months ago (2013-10-01 05:53:07 UTC) #1
kinaba
On 2013/10/01 05:53:07, mtomasz wrote: > @yoshiki: PTAL at *.js. > @kinaba: PTAL at *.cc. ...
7 years, 2 months ago (2013-10-01 08:48:29 UTC) #2
yoshiki
.js lgtm with nit https://codereview.chromium.org/25458002/diff/3001/chrome/browser/resources/image_loader/request.js File chrome/browser/resources/image_loader/request.js (right): https://codereview.chromium.org/25458002/diff/3001/chrome/browser/resources/image_loader/request.js#newcode264 chrome/browser/resources/image_loader/request.js:264: token, url, onInnerSuccess, onInnerFailure); nit: ...
7 years, 2 months ago (2013-10-01 08:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/25458002/9001
7 years, 2 months ago (2013-10-01 09:22:49 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-01 11:29:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/25458002/9001
7 years, 2 months ago (2013-10-01 23:18:44 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 00:28:21 UTC) #7
Message was sent while issue was closed.
Change committed as 226362

Powered by Google App Engine
This is Rietveld 408576698