Issue 2545753003: Compute top-level declarations in a file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2545753003: Compute top-level declarations in a file. (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Compute top-level declarations in a file. This is the first step to implement 'Add Import' Quick Fix with the new analysis driver. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1e5fc38884db4c387fdbc6fc85bee0607085dc04

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+135 lines, -0 lines)			Patch
M	pkg/analyzer/lib/src/dart/analysis/file_state.dart	View	6 chunks	+57 lines, -0 lines	0 comments	Download
A	pkg/analyzer/lib/src/dart/analysis/top_level_declarations.dart	View	1 chunk	+39 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/analysis/file_state_test.dart	View	2 chunks	+39 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Brian Wilkerson

It's unfortunate that we need to define TopLevelDeclaration here; seems like we already have enough ...

4 years ago (2016-12-01 19:30:35 UTC) #2

scheglov

4 years ago (2016-12-01 19:43:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1e5fc38884db4c387fdbc6fc85bee0607085dc04 (presubmit successful).