Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2545733002: chromecast: Cleanup class/struct fwd declarations (Closed)

Created:
4 years ago by jbriance
Modified:
4 years ago
Reviewers:
halliwell
CC:
chromium-reviews, cbentzel+watch_chromium.org, halliwell+watch_chromium.org, eme-reviews_chromium.org, posciak+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, alokp+watch_chromium.org, gfhuang+watch_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromecast: Cleanup class/struct fwd declarations Remove useless class and struct forward declarations, and add missing ones in chromecast header files. BUG=662195 Committed: https://crrev.com/f9cc288b79a33622b026d3096f744c029b2410e4 Cr-Commit-Position: refs/heads/master@{#435693}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -49 lines) Patch
M chromecast/browser/android/cast_window_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/android/cast_window_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/browser/cast_content_window.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/browser/devtools/remote_debugging_server.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/browser/metrics/cast_stability_metrics_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/audio/cast_audio_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/media/audio/cast_audio_mixer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cdm/cast_cdm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/media/cma/backend/alsa/audio_decoder_alsa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/backend/alsa/stream_mixer_alsa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/pipeline/decrypt_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/media/service/cast_renderer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chromecast/net/connectivity_checker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/net/network_change_notifier_factory_cast.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/public/media/media_pipeline_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/public/video_plane.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/renderer/cast_content_renderer_client.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chromecast/service/cast_service.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbriance
4 years ago (2016-12-01 12:30:18 UTC) #2
halliwell
On 2016/12/01 12:30:18, jbriance wrote: lgtm
4 years ago (2016-12-01 17:27:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545733002/1
4 years ago (2016-12-01 19:59:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:16:41 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-01 20:19:32 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f9cc288b79a33622b026d3096f744c029b2410e4
Cr-Commit-Position: refs/heads/master@{#435693}

Powered by Google App Engine
This is Rietveld 408576698