third_party/libtiff/0010-fix-leak-imagebegin.patch - Issue 2545723004: Fix a leak when TIFFRGBAImageBegin fails

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/libtiff/0010-fix-leak-imagebegin.patch

Issue 2545723004: Fix a leak when TIFFRGBAImageBegin fails (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/third_party/libtiff/tif_getimage.c b/third_party/libtiff/tif_getima ge.c

	2 index 8523793..97fa94d 100644

	3 --- a/third_party/libtiff/tif_getimage.c

	4 +++ b/third_party/libtiff/tif_getimage.c

	5 @@ -478,10 +478,7 @@ TIFFRGBAImageBegin(TIFFRGBAImage* img, TIFF* tif, int stop, char emsg[1024])

	6 return 1;

	7

	8 fail_return:

	9 - _TIFFfree( img->redcmap );

	10 - _TIFFfree( img->greencmap );

	11 - _TIFFfree( img->bluecmap );

	12 - img->redcmap = img->greencmap = img->bluecmap = NULL;

	13 + TIFFRGBAImageEnd(img);

	14 return 0;

	15 }

OLD	NEW

« no previous file with comments | « no previous file | third_party/libtiff/README.pdfium » ('j') | no next file with comments »