Fix a leak when TIFFRGBAImageBegin fails

Fix a leak when TIFFRGBAImageBegin fails

The method to create image can fail even after ycbcr has been set, so
the current way to release is not enough. TIFFRGBAImageEnd is safe in
that it checks for existence before deleting, and deletes whatever has
been created.

BUG=657473
Committed: https://pdfium.googlesource.com/pdfium/+/7341149c634e0ab9a619898826440f6e952cf0aa

[npm, 2016-12-01 21:00:34]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 21:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:12:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:12:23]

Dry run: This issue passed the CQ dry run.

[npm, 2016-12-01 21:24:32]

Description was changed from

==========
Fix a leak when TIFFRGBAImageBegin fails

The method to create image can fail even after ycbcr has been set, so
the current way to release is not enough. TIFFRGBAImageEnd is safe in
that it checks for existence before deleting, and deletes whatever has
been created.

BUG=657473
==========

to

==========
Fix a leak when TIFFRGBAImageBegin fails

The method to create image can fail even after ycbcr has been set, so
the current way to release is not enough. TIFFRGBAImageEnd is safe in
that it checks for existence before deleting, and deletes whatever has
been created.

BUG=657473
==========

[npm, 2016-12-01 21:24:32]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, ochang@chromium.org, stackexploit@gmail.com,
tsepez@chromium.org

[npm, 2016-12-01 21:26:15]

PTAL. Is there still something like an "official" libtiff repo or not any more?
In the ones I looked, this was not fixed.

[Tom Sepez, 2016-12-01 21:37:50]

LGTM.  Oliver may know about upstreaming patches.

[Oliver Chang, 2016-12-01 21:45:58]

On 2016/12/01 21:37:50, Tom Sepez wrote:
> LGTM.  Oliver may know about upstreaming patches.

Never dealt with upstream libtiff before, but maybe send an email to their
mailing list? (tiff@remotesensing.org)

[npm, 2016-12-01 21:52:04]

On 2016/12/01 21:45:58, Oliver Chang wrote:
> On 2016/12/01 21:37:50, Tom Sepez wrote:
> > LGTM.  Oliver may know about upstreaming patches.
> 
> Never dealt with upstream libtiff before, but maybe send an email to their
> mailing list? (mailto:tiff@remotesensing.org)

Ok, let's see if they reply. Either way I think it won't change the CL since it
looks like we're now manually logging our libtiff changes.

[Ke Liu, 2016-12-02 02:26:44]

On 2016/12/01 21:52:04, npm wrote:
> On 2016/12/01 21:45:58, Oliver Chang wrote:
> > On 2016/12/01 21:37:50, Tom Sepez wrote:
> > > LGTM.  Oliver may know about upstreaming patches.
> > 
> > Never dealt with upstream libtiff before, but maybe send an email to their
> > mailing list? (mailto:tiff@remotesensing.org)
> 
> Ok, let's see if they reply. Either way I think it won't change the CL since
it
> looks like we're now manually logging our libtiff changes.

As far as I know, they are still maintaining a CVS repository.
It seems that the official site has been moved to http://libtiff.maptools.org/

Anonymous CVS
export CVSROOT=:pserver:cvsanon@cvs.maptools.org:/cvs/maptools/cvsroot
cvs login
(use empty password)
cvs checkout libtiff
to get the stable libtiff code or
cvs checkout -r branch-3-9 libtiff
to get the previous stable branch supporting the 3.9.X release series.

[npm, 2016-12-05 16:27:05]

The CQ bit was checked by npm@chromium.org

[commit-bot: I haz the power, 2016-12-05 16:27:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 16:38:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480955225598450, "parent_rev":
"f6ee820732b8717d32d85a47938172080067ce4e", "commit_rev":
"7341149c634e0ab9a619898826440f6e952cf0aa"}

[commit-bot: I haz the power, 2016-12-05 16:38:38]

Description was changed from

==========
Fix a leak when TIFFRGBAImageBegin fails

The method to create image can fail even after ycbcr has been set, so
the current way to release is not enough. TIFFRGBAImageEnd is safe in
that it checks for existence before deleting, and deletes whatever has
been created.

BUG=657473
==========

to

==========
Fix a leak when TIFFRGBAImageBegin fails

The method to create image can fail even after ycbcr has been set, so
the current way to release is not enough. TIFFRGBAImageEnd is safe in
that it checks for existence before deleting, and deletes whatever has
been created.

BUG=657473

Committed:
https://pdfium.googlesource.com/pdfium/+/7341149c634e0ab9a619898826440f6e952c...
==========

[commit-bot: I haz the power, 2016-12-05 16:38:39]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/7341149c634e0ab9a619898826440f6e952c...