Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2545723002: [turbofan] Re-add bytecode analysis unit test (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Re-add bytecode analysis unit test Now that the BASE_EMBEDDED macro is gone, this should be safe. Originally removed in: https://codereview.chromium.org/2532103004/ Committed: https://crrev.com/6f6795b5082f5b4f893d0eb51f367c0ade2fa737 Cr-Commit-Position: refs/heads/master@{#41480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -0 lines) Patch
M test/unittests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A test/unittests/compiler/bytecode-analysis-unittest.cc View 1 chunk +415 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
Leszek Swirski
Hi Michael, Here's a revert of that deleted unit test, should be safe now but ...
4 years ago (2016-12-01 12:34:33 UTC) #6
Leszek Swirski
Hi Michael, I noticed other-Michael is OOO, so I'm wondering if you want to lgtm ...
4 years ago (2016-12-01 14:33:48 UTC) #8
Michael Achenbach
lgtm
4 years ago (2016-12-02 08:20:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545723002/1
4 years ago (2016-12-05 10:20:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 10:47:45 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 10:48:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f6795b5082f5b4f893d0eb51f367c0ade2fa737
Cr-Commit-Position: refs/heads/master@{#41480}

Powered by Google App Engine
This is Rietveld 408576698