Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2545703002: WebRTC overrides: Add linear histogram type w/ bucket count parameter (Closed)

Created:
4 years ago by hlundin-chromium
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebRTC overrides: Add linear histogram type w/ bucket count parameter This change adds a new histogram factory method that provides a count histogram but with linearly spaced buckets. BUG=none Committed: https://crrev.com/4cece88dddd3ee077ca7e528fb3c4b2664ac5384 Cr-Commit-Position: refs/heads/master@{#435676}

Patch Set 1 #

Patch Set 2 : Rename to HistogramFactoryGetCountsLinear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/webrtc_overrides/init_webrtc.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
hlundin-chromium
Åsa, Tommi, PTAL.
4 years ago (2016-12-01 10:00:42 UTC) #3
hlundin-chromium
I changed my mind. New implementation up for review.
4 years ago (2016-12-01 10:16:06 UTC) #5
tommi (sloooow) - chröme
is there an accompanied cl that uses the new function?
4 years ago (2016-12-01 10:20:53 UTC) #6
hlundin-chromium
On 2016/12/01 10:20:53, tommi (chrömium) wrote: > is there an accompanied cl that uses the ...
4 years ago (2016-12-01 10:29:51 UTC) #7
hlundin-chromium
On 2016/12/01 10:29:51, hlundin-chromium wrote: > On 2016/12/01 10:20:53, tommi (chrömium) wrote: > > is ...
4 years ago (2016-12-01 11:18:30 UTC) #8
asapersson2
lgtm
4 years ago (2016-12-01 12:37:08 UTC) #9
tommi (sloooow) - chröme
lgtm
4 years ago (2016-12-01 13:12:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545703002/20001
4 years ago (2016-12-01 18:02:10 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-01 19:27:38 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-01 19:30:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4cece88dddd3ee077ca7e528fb3c4b2664ac5384
Cr-Commit-Position: refs/heads/master@{#435676}

Powered by Google App Engine
This is Rietveld 408576698