Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2545683002: Move all descendant-dependent flags into the same tree walk. (Closed)

Created:
4 years ago by chrishtr
Modified:
4 years ago
Reviewers:
pdr., Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move all descendant-dependent flags into the same tree walk. BUG=646188 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/7c6d99f9312312984af26dfb466c04bdf02afc68 Cr-Commit-Position: refs/heads/master@{#436060}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -46 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp View 1 2 2 chunks +1 line, -23 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 2 3 4 4 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 2 3 4 9 chunks +31 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (19 generated)
chrishtr
4 years ago (2016-12-01 17:03:44 UTC) #10
pdr.
On 2016/12/01 at 17:03:44, chrishtr wrote: > This looks reasonable but a lot of tests ...
4 years ago (2016-12-02 00:23:10 UTC) #14
chrishtr
On 2016/12/02 at 00:23:10, pdr wrote: > On 2016/12/01 at 17:03:44, chrishtr wrote: > > ...
4 years ago (2016-12-02 01:38:56 UTC) #15
pdr.
LGTM
4 years ago (2016-12-02 01:51:32 UTC) #18
Xianzhu
lgtm
4 years ago (2016-12-02 22:14:35 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545683002/80001
4 years ago (2016-12-02 22:15:16 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-02 22:42:48 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-02 22:47:00 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7c6d99f9312312984af26dfb466c04bdf02afc68
Cr-Commit-Position: refs/heads/master@{#436060}

Powered by Google App Engine
This is Rietveld 408576698