Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 2545673002: Handle RuntimeException in MemoryMonitorAndroid.getMemoryInfo (Closed)

Created:
3 years, 8 months ago by bashi
Modified:
3 years, 8 months ago
Reviewers:
haraken, boliu
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle RuntimeException in MemoryMonitorAndroid.getMemoryInfo A RuntimeException can be thrown when we call ActivityManager.getMemoryInfo() when the system is going to restart. To avoid immediate crash, handle these exceptions gracefully. BUG=668966 Committed: https://crrev.com/373df2959fa6c45a292701e655066fb5c1b0e7a9 Cr-Commit-Position: refs/heads/master@{#435568}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Log exception #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java View 1 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
bashi
PTAL
3 years, 8 months ago (2016-12-01 01:44:11 UTC) #4
haraken
https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java File content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java (right): https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java#newcode50 content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java:50: sMemoryInfo.totalMem = 1; 1 => 0 ? Is there ...
3 years, 8 months ago (2016-12-01 01:46:42 UTC) #5
boliu
lgtm after haraken is happy https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java File content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java (right): https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java#newcode46 content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java:46: Log.e(TAG, "Failed to get ...
3 years, 8 months ago (2016-12-01 01:54:45 UTC) #6
bashi
https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java File content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java (right): https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java#newcode46 content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java:46: Log.e(TAG, "Failed to get memory info due to a ...
3 years, 8 months ago (2016-12-01 02:02:18 UTC) #7
haraken
On 2016/12/01 02:02:18, bashi1 wrote: > https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java > File > content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java > (right): > > ...
3 years, 8 months ago (2016-12-01 02:03:41 UTC) #8
bashi
https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java File content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java (right): https://codereview.chromium.org/2545673002/diff/1/content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java#newcode46 content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java:46: Log.e(TAG, "Failed to get memory info due to a ...
3 years, 8 months ago (2016-12-01 06:20:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2545673002/20001
3 years, 8 months ago (2016-12-01 06:20:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 8 months ago (2016-12-01 06:57:46 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2016-12-01 07:00:53 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/373df2959fa6c45a292701e655066fb5c1b0e7a9
Cr-Commit-Position: refs/heads/master@{#435568}

Powered by Google App Engine
This is Rietveld 408576698